fix Issue 16570 - Enum member with interpreted... #6175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...initializer has type of initializer not enum - There is a very old (dmd 0.50 [¹]) mismatch of the CastExp's `to` type and the type painted on the CastExp (the latter being the basetype of the former, i.e. EnumType vs. int) in the result of `Expression.castTo(ed.type)`. Because of that difference interpreting castTo might unexpectedly use the basetype instead of the enum type for the enum initializer, and thus triggers the can't convert int to EnumType error. - The trigger was introduced with the addition of a `e.ctfeInterpret` in denum.d (see 932be19). - Comments on CastExp suggest that this type mismatch is actually intended, I don't see any reason for it though. - Alternatively we could somehow fix ctfeInterpret to preserve CastExp's painted type. [¹]: https://github.com/dlang/dmd/blob/bde09435d149c699490bb888b832228e0d31c221/src/cast.c#L321-L323respect
|
|
Looks good to me, absent the CyberShadow/travis-ci failures. |
|
All unrelated, need to fix them, 3 failures by now. |
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...initializer has type of initializer not enum
totypeand the type painted on the CastExp (the latter being the basetype of
the former, i.e. EnumType vs. int) in the result of
Expression.castTo(ed.type).Because of that difference interpreting castTo might unexpectedly use
the basetype instead of the enum type for the enum initializer, and
thus triggers the can't convert int to EnumType error.
e.ctfeInterpretindenum.d (see 932be19).
intended, I don't see any reason for it though.
painted type.