Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen SIMD code for cast(bool)(a + b) #6238

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Conversation

WalterBright
Copy link
Member

It was using the x87 for this case.

Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind the failures

if (tyfloating(ty1))
{
if (*pretregs & XMMREGS || tyvector(ty1))
tym_t ty = tybasic(e->Ety);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent looks odd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old indent was 2, but as I modify code I fix it to 4.

@WalterBright WalterBright merged commit 16afbde into dlang:master Nov 6, 2016
@WalterBright WalterBright deleted the xmmadd branch November 6, 2016 04:13
@PetarKirov
Copy link
Member

This PR introduced a regresion - https://issues.dlang.org/show_bug.cgi?id=17087.

@CyberShadow
Copy link
Member

This pull request introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=17677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants