Fix7327 #635
Closed
Fix7327 #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when usNumops == 0 and emitting a vector instruction, popndTmp is left uninitialized and is later dereferenced.
…:scan In Lexer::peek, the code truncated the next list in the case where peek was reentrant. ie: ... peek ... ... peek ... In TOKpound processing, it should peek relative to the passed in token rather than the global current token.
initialize popndTmp rather than rely on carefulness
fix latent bug with Lexer::peek and recently introduced bug in Lexer::scan
Issue 7038 - Type mismatch with const struct
- resolve aliases in overload sets and nested overload sets
| @@ -323,8 +323,10 @@ struct OverloadSet : Dsymbol | |||
|
|
|||
| OverloadSet(); | |||
| void push(Dsymbol *s); | |||
| virtual int isOverloadable(); | |||
There was a problem hiding this comment.
DMD "coding convention" - isOverloadable already exist in Dsymbol..
|
I wonder to what extent this moves forward toward overloading as described in TDPL. That is long overdue... |
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Update putAArray for non-x86 architechtures.
|
ping - please rebase and let's take this home |
|
reping |
|
I'll have to rewrite this. We're now doing another overload resolution to check for |
|
But the fix is pretty simple, we only need to add |
|
@dawgfoto okay to close this for now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=7327