iasm.d: rework to remove all storage allocation #6379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
force-pushed
the
iasm-no-new
branch
3 times, most recently
from
f4afa51 to
948fb2e
Compare
WalterBright
force-pushed
the
iasm-no-new
branch
from
948fb2e to
2675ce1
Compare
|
|
andralex
approved these changes
Jan 3, 2017
| o1 = (o1.disp) ? o2 : o3; | ||
| OPND o3; | ||
| asm_cond_exp(o3); | ||
| if (o1.disp) |
There was a problem hiding this comment.
use ternary op? o1 = o1.disp ? o2 : o3;
|
again seeing coverage issues |
|
The coverage issues were there before, and are an issue for another PR. |
|
This pull request introduced a regression: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace new/delete with stack locals.