Fix issue 17073 - Do not ignore the explicit initializers #6427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ibuclaw
reviewed
Jan 12, 2017
| @@ -0,0 +1,13 @@ | |||
| struct S0 | |||
There was a problem hiding this comment.
Probably should be named test17073.d.
There was a problem hiding this comment.
Since the test case is limited to this file I don't think the name really matters
We don't really care about the _init being void-initialized when the user has supplied an explicit value for a given field of the aggregate.
|
Rebased onto stable b/c it's a bugfix (in this case even a regression fix). Fixes should almost always go into stable unless they are risky. |
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really care about the _init being void-initialized when the
user has supplied an explicit value for a given field of the aggregate.
And yes, the check is ugly, suggestions are welcome.