-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 17096 - Check the number of arguments given to __trait #6456
Conversation
|
|
@LemonBoy may I suggest an alternative approuch ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, need @LemonBoy to rebase
|
BTW on some PRs I can fix conflicts by my own on the github website, why is this not available here? |
|
@stefan-koch-sociomantic do you think you can adopt this PR? |
@stefan-koch-sociomantic I'll revive it, unless you really want it. @andralex I think there are others in the PR queue that could be revived. If you find one, and are willing to review it in a timely manner, let me know and I'll revive it. @LemonBoy Thanks for all the work you did in the DMD repository. I'm sorry it wasn't considered a priority. I'll try to keep at least some of it from being lost. |
|
@JinShil go for it, thanks! That's a great offer. I'll look into others. cc @WalterBright @MartinNowak |
|
@JinShil Thanks for taking it. |
|
#7330 was merged, so this can be closed. |
|
@JinShil I think it's time to expand your responsibilities. I've invited you as an owner at Team Phobos. |
No description provided.