Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 17096 - Check the number of arguments given to __trait #6456

Closed
wants to merge 1 commit into from
Closed

Fix issue 17096 - Check the number of arguments given to __trait #6456

wants to merge 1 commit into from

Conversation

LemonBoy
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
17096 many traits accept an invalid parameter count without error

@UplinkCoder
Copy link
Member

@LemonBoy may I suggest an alternative approuch ?
make dimError(uint expected) into dimError(uint expcted, uint actual);

Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need @LemonBoy to rebase

@andralex
Copy link
Member

BTW on some PRs I can fix conflicts by my own on the github website, why is this not available here?

@stefan-koch-sociomantic

@andralex it seems @LemonBoy does no longer have a dmd repo.
I guess his patience has reached the limit.

@andralex
Copy link
Member

@stefan-koch-sociomantic do you think you can adopt this PR?

@JinShil
Copy link
Contributor

JinShil commented Nov 17, 2017

@stefan-koch-sociomantic do you think you can adopt this PR?

@stefan-koch-sociomantic I'll revive it, unless you really want it.

@andralex I think there are others in the PR queue that could be revived. If you find one, and are willing to review it in a timely manner, let me know and I'll revive it.

@LemonBoy Thanks for all the work you did in the DMD repository. I'm sorry it wasn't considered a priority. I'll try to keep at least some of it from being lost.

@andralex
Copy link
Member

@JinShil go for it, thanks! That's a great offer. I'll look into others. cc @WalterBright @MartinNowak

@JinShil
Copy link
Contributor

JinShil commented Nov 17, 2017

Revived at #7330
cc @andralex

@stefan-koch-sociomantic

@JinShil Thanks for taking it.

@JinShil
Copy link
Contributor

JinShil commented Nov 18, 2017

#7330 was merged, so this can be closed.

@andralex
Copy link
Member

@JinShil I think it's time to expand your responsibilities. I've invited you as an owner at Team Phobos.

@andralex andralex closed this Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants