fix Issue 17087 - [REG2.072] Wrong generated with cfloat and creal wh… #6460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WalterBright
force-pushed
the
fix17087
branch
from
5902d57 to
8eb32ca
Compare
yebblies
reviewed
Jan 17, 2017
| @@ -4411,7 +4411,7 @@ elem *toElem(Expression e, IRState *irs) | |||
| case X(Tfloat64,Tcomplex32): | |||
| case X(Tfloat64,Tcomplex64): | |||
| case X(Tfloat64,Tcomplex80): | |||
| e = el_bin(OPadd,TYcfloat,el_long(TYidouble,0),e); | |||
| e = el_bin(OPadd,TYcdouble,el_long(TYidouble,0),e); | |||
There was a problem hiding this comment.
Why is cdouble more correct that cfloat? This seems to cover float, double and real.
There was a problem hiding this comment.
Because its operands are double, and the next line assumes its type is cdouble.
…en casting from int
|
Auto-merge toggled on (after rebasing onto stable). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en casting from int
Looks like the problem was a very old copy/pasta error.