fix Issue 17130 - ambiguous implicit super call

[MartinNowak]

• need type of this to resolve base class ctor overloads

[dlang-bot]

Fix	Bugzilla	Description
✓	17130	[Reg 2.074] ambiguous implicit super call when inheriting core.sync.mutex.Mutex

[PetarKirov]

Thanks for fixing this so fast!

Strangely vibe.d still fails with:

source/vibe/core/core.d(1183,18): Error: function vibe.core.core.CoreTask.state cannot override final function core.thread.Fiber.state

Which is quite strange, because Fiber.state has been marked as final for quite some time:
https://github.com/dlang/druntime/blob/druntime-2.052/src/core/thread.d#L3226

I have no idea how vibe.d managed to override it before my PR in the first place. Sound like another compiler bug.

[MartinNowak]

See Issue 17131 – [Reg 2.074] Fiber.state collides with differently attributed function in derived class for the other issue.

[PetarKirov]

@MartinNowak I guess you need to force push your branch to re-trigger the project tester since @s-ludwig worked around that bug in vibe-d/vibe.d@74883bc.

Edit: I see now that force pushing won't work because this omits tags tags like v0.7.31-beta.2 and v0.8.0-beta.2. I guess that was deliberate to leave only "stable" tags, so probably special-casing vibe.d would be the easiest solution for now.

[MartinNowak]

Can we please just merge this, it obviously fixes the super overload issue. The functions should have never been overload/rideable which asks for a separate dmd fix.
https://issues.dlang.org/show_bug.cgi?id=17131

[UplinkCoder]

@MartinNowak go ahead an merge it yourself.

[MartinNowak]

Auto-merge toggled on