Fix bug 6451

[mrmonday]

Fix bug 6451 - [64bit] ICE(expression.c:4434): SymbolExp::SymbolExp(Loc,... TOK, int, Declaration*, int): Assertion `var' failed.

[WalterBright]

In the future, please include additions to the test suite when fixing bugs. In this case, the example from the bug report:

void error(...){}

should be written into a file named fail6451.d and added to the directory dmd/test/fail_compilation.

[mrmonday]

I wasn't sure how to test this, for several reasons:

• void error(...){} compiles just fine on 32bit, it only errors on x64 (I guess version could handle that)
• Testing at as fail compilation doesn't check that there's no ICE

Perhaps something like the following would work (untested):

version (X86_32)
{
    void error(...) {}
}
else version (X86_64)
{
    static assert(!is(typeof(void error(...) {})));
    import core.vararg;
    static assert(is(typeof(void error(...) {})));
}

Though this still doesn't check for what this pull request fixes (the ICE).

[WalterBright]

Testing does check for seg faults, and those are test failures. The fail tests are supposed to return an exit value of 1, not a seg fault.

Please add your revised test as a pull request.