Issue 4958 - Floating point enums should check for total loss of precision #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -231,6 +231,13 @@ void EnumDeclaration::semantic(Scope *sc) | |||
| e = e->semantic(sce); | |||
| e = e->castTo(sce, elast->type); | |||
| e = e->optimize(WANTvalue | WANTinterpret); | |||
|
|
|||
There was a problem hiding this comment.
How about if (t->isfloating())?
And while your at it you could cache that t->getProperty(0, Id::max) 5 lines above.
…ision This is Don's fix from the bug report. Issue an error if last+1 == last when assigning values to enum members.
WalterBright
added a commit
that referenced
this pull request
Feb 25, 2012
Issue 4958 - Floating point enums should check for total loss of precision
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Use errno property instead of setErrno in std.path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Don's fix from the bug report. Issue an error if last+1 == last when assigning values to enum members.
http://d.puremagic.com/issues/show_bug.cgi?id=4958