fix Issue 17335 - Function calls in conjunctions do not short circuit… #6713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
… when evaluated during compilation
andralex
approved these changes
Apr 21, 2017
| result = evalStaticCondition(sc, exp, leg, errors); | ||
| return !errors && result; | ||
| } | ||
|
|
There was a problem hiding this comment.
Nice, but what if the user introduces a redundant set of parens?
static if ((cond1 && cond2)) ...Then the top-level node is a TOKparen or whatevs, and would hide the conjunction inside. Is that the case? If so, it needs to be handled too.
There was a problem hiding this comment.
There are no paren expressions in the AST. (a+b) is the same AST as a+b. Parens are for grouping.
| static if (!alwaysFalse() ? 1 : f == 1) | ||
| { | ||
| } | ||
| } |
There was a problem hiding this comment.
So the extra test here would be all of the above in one level of parens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… when evaluated during compilation
Also fix https://issues.dlang.org/show_bug.cgi?id=17334