-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DMD work with a struct as the main integral type #6743
Conversation
|
Seems reasonable, though this is proof of concept by the looks. |
|
What is the purpose of this? |
|
It is the base of my cent/ucent implementation. As I can't use a cent/ucent I need to use a struct for emulation. This PR introduces the struct only. |
|
This is also the case for |
| @@ -465,13 +465,13 @@ extern (C++) MATCH implicitConvTo(Expression e, Type t) | |||
| { | |||
| if (e.type.isunsigned()) | |||
| { | |||
| const f = real_t(value); | |||
| const f = cast(real_t)value; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially casting between two software emulation types, yummy. 😋
|
Yes, the intent is to find all uses of implicit construction and conversion where a struct implementing 128bit support can't be dropped in. If we are going to move forward with cent/ucent then this will need to be done, and it will be easier to debug and review without the actual 128bit changes. |
|
I like this, it's akin to dogofooding. Less magic keeps us all more honest. Any chance this can be revived? |
|
The PR needs to be broken down into manageable pieces. As and if I get round to it. It's important for supporting |
|
Made some headway a number of years ago, rebased the branch on master now. |
|
Closing this considering it is orphaned, and |
|
Reopening this. Friend don't let friend make completely r*****ed decision such as deprecating |
|
Thanks for your pull request, @yebblies! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#6743" |
|
I understand you're upset that there's no plan to implement |
|
This is work that we're going to do at some point in the future anyway, irrespective of |
@redstar