Fix compiler-inserted destructor call on shared objects #6752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atilaneves
force-pushed
the
fix_shared_dtor
branch
2 times, most recently
from
8a5e658
to
9acc62c
Compare
src/ddmd/declaration.d
Outdated
| shared or unshared. The constructor(s) can template on the type of | ||
| this to share implementations between shared and unqualified. The | ||
| destructor, however, is always a single function. | ||
| */ |
There was a problem hiding this comment.
The comment is unnecessarily wordy. How about:
Enable calling destructors on shared objects. The destructor is always a single, non-overloaded function, and must serve both shared and non-shared objects.
9acc62c
to
afb902a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a struct can be used as both shared and not when the constructor (and other functions) are templated on this. Defining a destructor breaks this because destructors can't be templated, and the non-shared destructor call on a shared
thisfails. This patch fixes this in a manner similar to how the compiler already treats destructor calls onimmutableandconstobjects: by casting it away.Since the compiler-generated destructor call is always scoped, only one thread is destroying it anyway.