fix Issue 16197 - Constructors/postblits and destructors don't match … #6774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…up for array initialisation
andralex
reviewed
May 14, 2017
| static string r; | ||
| int x = -1; | ||
| this(this) { r ~= 'p'; printf("POSTBLIT %d\n", x++); } | ||
| ~this() { r ~= 'd'; printf("DTOR %d\n" , x++); } |
There was a problem hiding this comment.
One unpleasant consequence of this idiom: calling ~= in a destructor causes reallocation which may cause garbage collection, which aborts the program...
There was a problem hiding this comment.
True, but this is a test case only, and in this case the destructors are not being called by the gc. So it's all right here.
There was a problem hiding this comment.
The problem is real - it did occur in some of Lucia's code.
There was a problem hiding this comment.
I know it is real, but not for this test case. It is only a problem when the GC is calling the destructors. That is not the case here, RAII is calling the destructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…up for array initialisation