remove .sort / .reverse properties and adjust tests #6827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UplinkCoder
force-pushed
the
remove_arrayProps
branch
from
0523dd9 to
b33fdc8
Compare
UplinkCoder
changed the title
UplinkCoder
force-pushed
the
remove_arrayProps
branch
3 times, most recently
from
357606a to
1bfcef7
Compare
|
Doesn't |
UplinkCoder
force-pushed
the
remove_arrayProps
branch
2 times, most recently
from
f894e54 to
423499c
Compare
|
@mathias-lang-sociomantic I originally intended for the idgen change to be in a separate PR |
|
@andralex ready for merge. |
|
cc @MartinNowak for deployment as he sees fit |
UplinkCoder
force-pushed
the
remove_arrayProps
branch
3 times, most recently
from
415fe00 to
5cabbd0
Compare
|
There are still a few tests to fix up.. |
UplinkCoder
force-pushed
the
remove_arrayProps
branch
13 times, most recently
from
2e98876 to
32a035a
Compare
|
@MartinNowak this passes now. |
UplinkCoder
changed the title
yebblies
reviewed
May 28, 2017
test/runnable/foreach4.d
Outdated
| @@ -840,7 +840,6 @@ void test26() | |||
| assert(i == 2); | |||
| assert(a.array[0] == 73); | |||
| assert(a.array[1] == 82); | |||
|
|
|||
test/runnable/test12.d
Outdated
| return std.algorithm.cmp(this.str, s.str); | ||
| } | ||
| } | ||
|
|
||
| void test45() | ||
| { | ||
| import std.algorithm; | ||
| import std.range; |
test/runnable/test4.d
Outdated
| { | ||
| real[10] array; | ||
| real[] copy = array.dup; | ||
| copy.sort; |
test/runnable/wc2.d
Outdated
| @@ -66,7 +66,7 @@ int main (string[] args) | |||
| } | |||
|
|
|||
| printf("--------------------------------------\n"); | |||
|
|
|||
| import std.algorithm.sorting : sort; | |||
UplinkCoder
force-pushed
the
remove_arrayProps
branch
from
285203b to
525d66b
Compare
|
@yebblies addressed your comments |
MartinNowak
requested changes
Jun 6, 2017
There was a problem hiding this comment.
Short changelog notice, otherwise good to go from my side.
https://github.com/dlang/dmd/tree/master/changelog
|
thx you guys - @UplinkCoder changelog and we should be good to go |
|
@andralex Martin amended the changelog entry already |
MartinNowak
approved these changes
Jun 6, 2017
|
PR for dlang.org: dlang/dlang.org#1672 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per title
This is a revamp of #6554