Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert #6816 to due to excessive code breakage #6913

Merged
merged 2 commits into from
Jun 17, 2017
Merged

revert #6816 to due to excessive code breakage #6913

merged 2 commits into from
Jun 17, 2017

Conversation

MartinNowak
Copy link
Member

@MartinNowak MartinNowak commented Jun 17, 2017 •
edited
Loading

Commenting out dlang.org dlang/dlang.org#1719.

@MartinNowak
Revert "Merge pull request dlang#6816 from WalterBright/fix14246"
29deed3 
This reverts commit 6b3d406, reversing
changes made to c6c3c11.
@MartinNowak
add test cases for existing production code
558773e 
- fixes Issues 17494, 17505, 17506
@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
✓ 17494 Do not execute scope(...) if an Error exception has been thrown
✓ 17505 [REG2.075] @safe constructor requires the deconstructor to be safe as well
✓ 17506 [REG2.075] @disable constructor requires members to be initialized

@MartinNowak MartinNowak mentioned this pull request Jun 17, 2017
Merged
wilzbach
wilzbach approved these changes Jun 17, 2017
View reviewed changes
Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already proposed a revert in #6899, but of course adding the tests as fixture is highly appreciated :)
Looking forward to be able to enforce the Project Tester again!

@MartinNowak MartinNowak mentioned this pull request Jun 17, 2017
Closed
@dlang-bot dlang-bot merged commit a632e3f into dlang:master Jun 17, 2017
This was referenced Jun 17, 2017
Closed
Closed
Closed
Closed
Closed
@MartinNowak MartinNowak deleted the revert_riia_ctor_due_to_regressions branch June 17, 2017 11:22
@CyberShadow
Copy link
Member

Jenkins finally looks green again.

Shall we set it as required once more?

@wilzbach
Copy link
Member

Jenkins finally looks green again.
Shall we set it as required once more?

Yes please. Tracking regressions down is a very exhausting job

@MartinNowak
Copy link
Member Author

Shall we set it as required once more?

Already done 3 hours ago ;).

@MartinNowak
Copy link
Member Author

This is a good example of how reliant we are on testing external projects.

@JinShil JinShil mentioned this pull request Jan 29, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilzbach wilzbach wilzbach approved these changes

@WalterBright WalterBright WalterBright approved these changes

Assignees
No one assigned
Labels
Merge:auto-merge Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinNowak @dlang-bot @CyberShadow @wilzbach @WalterBright