Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor XxxAssignExp semantic #695

Merged
merged 1 commit into from
Feb 20, 2012

Conversation

yebblies
Copy link
Member

@yebblies yebblies commented Feb 5, 2012

Reduce code duplication for the semantic routines of +=, -=, *=, /=, %=, &=, |=, ^=, <<=, >>=, >>>=

The semantic routines for these operators are nearly identical, and a lot of the differences are probably bugs.

Most of the remaining special casing is due to imaginary and complex types, which can be delete when those types are removed from the language.

In the process fix issues 7439 and 5181. (and possibly others)

http://d.puremagic.com/issues/show_bug.cgi?id=5181
http://d.puremagic.com/issues/show_bug.cgi?id=7439

@braddr
Copy link
Member

braddr commented Feb 5, 2012

doesn't pass testing:
../src/dmd -m32 -Irunnable -odtest_results/runnable -oftest_results/runnable/xtest46_0 runnable/xtest46.d
runnable/xtest46.d(1722): basic type expected, not {
runnable/xtest46.d(1722): found '{' when expecting ')'
runnable/xtest46.d(1723): found 'alias' when expecting ')'
runnable/xtest46.d(1723): { } expected following aggregate declaration

Your new test contains a typo.. did you run it before submitting the pull request? :)

@yebblies
Copy link
Member Author

yebblies commented Feb 5, 2012

Heh, nope. (not after the last set of changes) The amazing autotester has made me lazy and careless :) (and more productive).

Reduce code duplication for the semantic routines of `+=`, `-=`, `*=`, `/=`, `%=`, `&=`, `|=`, `^=`, `<<=`, `>>=`, `>>>=`

Most of the remaining special casing is due to imaginary and complex types.

In the process fix issues 7439 and 5181.
@Trass3r
Copy link
Contributor

Trass3r commented Feb 15, 2012

github really should have a voting system for pull requests :)

WalterBright added a commit that referenced this pull request Feb 20, 2012
@WalterBright WalterBright merged commit 34cb3de into dlang:master Feb 20, 2012
braddr pushed a commit to braddr/dmd that referenced this pull request Oct 22, 2012
Deprecated std.file.listDir.
@yebblies yebblies deleted the refactor_expression branch March 25, 2016 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants