Fix bug 7424 and bug 7425. #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit contains two changes: 1. It is now *allowed* to call an `inout` method from a method with any const qualifiers, which also allows an `inout` method template be matched from other non-`inout` methods, thus fixing bug 7425; 2. When resolveProperty failed to compute the type of an expression, the type is now set as TypeError instead of leaving as NULL, thus fixing bug 7424.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit contains two changes:
inoutmethod from a method with anyconst qualifiers, which also allows an
inoutmethod template bematched from other non-
inoutmethods, thus fixing bug 7425;type is now set as TypeError instead of leaving as NULL, thus fixing
bug 7424.