Error messages with __error: 6699, 7462, 7463 #704
Conversation
If there are any errors in the explicit template parameters, don't try to deduce the template -- it will certainly fail. Fixes bug 6699.
| { Object *o = targsi->tdata()[k]; | ||
| Expression *checkarg = isExpression(o); | ||
| Type *txx = isType(o); | ||
| if (checkarg && checkarg->op == TOKerror) |
There was a problem hiding this comment.
template.c has isError which is similar to what you're doing here.
Error messages with __error: 6699, 7462, 7463
|
When doing these, please add commit messages of the form "fix issue nnnn". Otherwise, bugzilla has to be manually updated. |
|
On 18 February 2012 08:08, Walter Bright
They were included in this one. |
|
github didn't recognize them, and it didn't get posted to bugzilla. I saw just "fix for 6699" which I don't think is recognized. Please use "fix issue nnnn". |
|
On 18 February 2012 09:07, Walter Bright
The text was "Fixes bug 6699." /((close|fix|address)e?(s|d)? )?(ticket|bug|tracker item|issue)s?:? I wonder why it didn't work. Please use "fix issue nnnn".
|
Fix cstream.printf() on x86_64.
The motivation for fixing these is not much that the error messages improve, but rather that it protects other parts of the compiler (eg, CTFE) from having to deal with garbage. OTOH, the fix for 6699a noticeably improves error message quality. (Don't try to deduce a function template, if one of the template arguments is an error).
6699 More cases of __error in error messages
7462 Error message with error in overridden function
7463 Duplicated error message with bad template value parameter