Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7462 - Error message with _error_ in overridden function #705

Closed
wants to merge 1 commit into from

Conversation

yebblies
Copy link
Member

When there is an error in the parameter types, default arguments or return type, propagate the error to the function's type.

http://d.puremagic.com/issues/show_bug.cgi?id=7462

When there is an error in the parameter types, default arguments or return type, propagate the error to the function's type.
@donc
Copy link
Collaborator

donc commented Feb 10, 2012

This was already in my pull. I actually entered the bug after I had a fix for it!
Sorry.

@donc
Copy link
Collaborator

donc commented Feb 10, 2012

Ah, interesting. This pull is primarily a fix for bug 7479. There's multiple issues, involved, since bug 7479 was a regression.

@yebblies
Copy link
Member Author

Ah, I knew I'd seen a special-cased check for the return type being Type::terror somewhere, no wonder I couldn't find it in func.c.
Apart from 4269 I can't remember where I've run into this before, and I think there are/were also some issues with TypeSArray::semantic.

@yebblies
Copy link
Member Author

Heh, it turns out this can cause crashes in several places because there are a bunch of assumptions that FuncDeclaration->type is always a TypeFunction.

@yebblies
Copy link
Member Author

There are a lot of places in the code that assume FuncDeclaration::type is always a TypeFunction. Closing this until I can be sure it's fixed everywhere.

@yebblies yebblies closed this Feb 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants