Issue 3822 - Invalid optimization of alloca called with constant size #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2ir.c constains an optimization to turn alloca into a fixed sized array allocation on the stack when alloca is called with a compile-time constant. This is invalid as alloca may be called inside a loop.
WalterBright
added a commit
that referenced
this pull request
Feb 19, 2012
Issue 3822 - Invalid optimization of alloca called with constant size
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Switch std.algorithm/.range to lambda syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2ir.c constains an optimization to turn alloca into a fixed sized array allocation on the stack when alloca is called with a compile-time constant. This is invalid as alloca may be called inside a loop.
I think the correct place to perform this optimization is in the backend, where analysis can determine alloca is called at most once per function call and turn it into a local variable allocation.
http://d.puremagic.com/issues/show_bug.cgi?id=3822