Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 17812 - crash when building JSON info with static foreach #7127

Merged
merged 3 commits into from
Sep 9, 2017

Conversation

tgehr
Copy link
Contributor

@tgehr tgehr commented Sep 7, 2017

This adds the string representation "__local" for STClocal.

@dlang-bot
Copy link
Contributor

dlang-bot commented Sep 7, 2017

Thanks for your pull request, @tgehr! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close Bugzilla Description
17812 crash when building JSON info with static foreach

@rainers
Copy link
Member

rainers commented Sep 8, 2017

Isn't __local something that should be invisible to the user?

Anyway, the reference JSON file needs to be updated with the new declarations.

@tgehr
Copy link
Contributor Author

tgehr commented Sep 8, 2017

@rainers: I don't exactly know the purpose of the json/vcg-ast output. (I was not really aware of -X and -vcg-ast, that's why I hadn't tested them.) I have removed __local declarations from the output of both in the respective pull requests. I have updated the json test.

@tgehr
Copy link
Contributor Author

tgehr commented Sep 8, 2017

Any ideas why the auto-tester fails cpp_abi_tests.d? (I have not even come close to code dealing with the C++ ABI.)

@rainers
Copy link
Member

rainers commented Sep 8, 2017

Any ideas why the auto-tester fails cpp_abi_tests.d?

It looks like it is still failing on the json output. The shell script for comparing with json.out filters out the file names.

@tgehr
Copy link
Contributor Author

tgehr commented Sep 8, 2017

@rainers Thanks! The auto-tester is green now.

@dlang-bot dlang-bot merged commit d3eff82 into dlang:stable Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants