Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 17878 - Add __traits(isFuture, ...) #7232

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

RazvanN7
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close Bugzilla Description
17878 Add __traits(isFuture, ...)

@andralex
Copy link
Member

cc @WalterBright @leandro-lucarella-sociomantic

@WalterBright
Copy link
Member

Need spec pull, too.

@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Oct 24, 2017

@WalterBright First, we should have @future into the specs and then the isFuture trait.

I made a PR anyway, but a link to what @future does, should be added.

dlang/dlang.org#1916

@andralex
Copy link
Member

I'll merge this and the spec pull, let me know if further additions are necessary.

@andralex andralex merged commit 51bc2fb into dlang:master Oct 24, 2017
@leandro-lucarella-sociomantic
Copy link
Contributor

Please, always state that this is a supposedly hidden, experimental feature, and link to the DIP. It will confuse people if we start adding wrong docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants