fix Issue 17246 - [REG2.053] Extra destructor call. #7238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Then shouldn't it target stable ? |
|
@andralex : Why did you merge it in master despite the review ? |
|
@mathias-lang-sociomantic leaving the decision to @MartinNowak the build czar |
|
And if it goes into stable, Martin has to cherry-pick it. We never merge master into stable, always the other way around. So if there's a reasonable doubt about a P.R. needing to go to stable, it shouldn't be merged right away like it just happened. |
|
Cool, @MartinNowak please advise on how you prefer to proceed. |
| @@ -1483,16 +1483,20 @@ extern (C++) bool preFunctionParameters(Loc loc, Scope* sc, Expressions* exps) | |||
| */ | |||
| extern (C++) Expression valueNoDtor(Expression e) | |||
| { | |||
| if (e.op == TOKcall) | |||
| auto ex = e; | |||
| while (ex.op == TOKcomma) | |||
There was a problem hiding this comment.
This is such a common thing it's time we factor it into a function isn't it ?
tramker
pushed a commit
to tramker/dmd
that referenced
this pull request
Feb 8, 2018
fix Issue 17246 - [REG2.053] Extra destructor call. cherry-picked-by: Martin Krejcirik <mk@krej.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a critical bug fix, as it can corrupt memory.