fix Issue 7997 - Optlink issues 'Index Range' error with static zero … #7243
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla references
|
| { | ||
| /* Give it a byte of data | ||
| * so we can take the 'address' of this symbol | ||
| * and avoid problematic behavior of object file format |
There was a problem hiding this comment.
avoid problematic behavior of object file format
Isn't this more Optlink incorrectly handling the object file format than an error in the object file format. A patch should be made to fix Optlink instead of creating a workaround for it here, with a vague comment that doesn't mention what it actually is: an Optlink bug.
There was a problem hiding this comment.
Optlink is much more difficult to look into so I'll take this.
There was a problem hiding this comment.
Similar problems happen with other object file formats.
I'm not sure one could call it a 'bug' in the file format anyway. What does it mean to take the address of a 0 length object? Should the object file format decide that?
A similar thing happens with empty C++ structs:
struct S { };
S* p = new S();
What happens? Weird problems can arise, so the standard devised a simple solution - it gives it a size of 1. The problems go away.
|
Coverage testing is done on Linux, so OSX specific code isn't covered. |
…length array