Fix bug 7399: Broken import statement in trySemantic() causes silent compiler error #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compiler error This patch is a hack. It make `Module::read()` not to call `fatal()` when the system is gagging, and make `Module::load()` return NULL when read failed. Some null-checks are introduced in several other places as a result. Proper fix would require exceptions be enabled (by using a `throw` statement instead of `exit(EXIT_FAILURE)`) and incorporate RAII, which would be too difficult to change at this stage.
This was referenced Feb 16, 2012
Closed
WalterBright
added a commit
that referenced
this pull request
Feb 23, 2012
Fix bug 7399: Broken import statement in trySemantic() causes silent compiler error
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Fix for regression bug# 8450.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=7399
This patch is a hack. It make
Module::read()not to callfatal()when the system is gagging, and makeModule::load()return NULL when read failed. Some null-checks are introduced in several other places as a result.Proper fix would require exceptions be enabled (by using a
throwstatement instead ofexit(EXIT_FAILURE)infatal()) and incorporate RAII, which would be too difficult to change at this stage.