Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 16183 - [REG2.068] compile-time string concatenation fails … #7298

Merged
merged 1 commit into from
Nov 11, 2017
Merged

Fix Issue 16183 - [REG2.068] compile-time string concatenation fails … #7298

merged 1 commit into from
Nov 11, 2017

Conversation

JinShil
Copy link
Contributor

@JinShil JinShil commented Nov 10, 2017

…with CTFE and char[] literal involved

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close Bugzilla Description
16183 [REG2.068] compile-time string concatenation fails with CTFE and char[] literal involved

@UplinkCoder
Copy link
Member

Looks good afaict

@dlang-bot dlang-bot merged commit 12964b3 into dlang:stable Nov 11, 2017
@JinShil JinShil deleted the fix16183 branch November 27, 2017 02:12
tramker pushed a commit to tramker/dmd that referenced this pull request Feb 8, 2018
Fix Issue 16183 - [REG2.068] compile-time string concatenation fails …
merged-on-behalf-of: Walter Bright <WalterBright@users.noreply.github.com>

cherry-picked-by: Martin Krejcirik <mk@krej.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants