Issue 5879 - Not all frontend errors use stderr #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fails autotester |
Use fprintf(stderr) in iasm.c, and stop using root::error in the frontend. Most cases are obvious mistakes where code has been refactored into free functions and ended up calling error without a loc. This makes all frontend errors correctly print to stdmsg (stderr) and fixes five unreported 'no line number' bugs. Removing error/warning from the root headers prevents these cases from creeping back in.
|
Missed one non-windows error. Should be good now. |
| @@ -32,9 +32,6 @@ | |||
|
|
|||
| int bstrcmp(unsigned char *s1, unsigned char *s2); | |||
| char *bstr2str(unsigned char *b); | |||
| void error(const char *format, ...); | |||
| void error(const wchar_t *format, ...); | |||
| void warning(const char *format, ...); | |||
There was a problem hiding this comment.
I always hated these guys, and tried to get rid of them once before. I did a big purge of all calls to them at one stage, but they keep creeping back.
There was a problem hiding this comment.
I think about half the no line number bugs have been caused by these, with the rest being generated code that doesn't bother propagating the loc.
WalterBright
added a commit
that referenced
this pull request
Mar 12, 2012
Issue 5879 - Not all frontend errors use stderr
WalterBright
added a commit
that referenced
this pull request
Mar 12, 2012
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Fix Issue 8516 - std.string.representation works incorrect for shared(const(T)) types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
fprintf(stderr)iniasm.c, and stop usingroot::errorin the frontend. Most cases are obvious mistakes where code has been refactored into free functions and ended up calling error without aloc.This makes all frontend errors correctly print to
stdmsg(stderr) and fixes five unreported 'no line number' bugs.Removing
error/warningfrom the root headers prevents these cases from creeping back in.http://d.puremagic.com/issues/show_bug.cgi?id=5879