fix Issue 16621 - [REG2.060] DMD hang in semantic3 on alias this

[WalterBright]

No description provided.

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close	Bugzilla	Description
✓	16621	[REG2.060] DMD hang in semantic3 on alias this

[JinShil]

@wilzbach I know we're right on the cusp of a release. Should this be in stable or master?

[WalterBright]

Since it's over a year old, master is fine.

[wilzbach]

TL;DR Safe fixes should always go into stable, all the time.

https://wiki.dlang.org/DIP75#Branching_strategy

[JinShil]

Pending rebase to stable... or not... Walter's call.

[wilzbach]

I know we're right on the cusp of a release.

FYI: 2.078.0 has already been tagged a couple of hours ago (https://github.com/dlang/dmd/releases/tag/v2.078.0).

[PetarKirov]

Yes, we should target stable so the changes can land in the 2.078.1 release.

[wilzbach]

FYI: We can always trivial merge stable back into master. Here's the simple script I use:

#!/bin/bash
set -ueo pipefail -o xtrace
DIR=${1:-$(pwd)}
pushd $DIR
git fetch && git fetch upstream
git checkout master
git merge --ff-only upstream/master
git branch -D merge_stable
git checkout -b merge_stable
git merge upstream/stable
# <- Solve merge conflicts (if any occurred)
hub pull-request
git checkout master
popd

[wilzbach]

We can always trivial merge stable back into master.

#7598