[Trivial] Fix super.visit issue in SemanticTimeTransitiveVisitor #7635
Conversation
|
Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
RazvanN7
changed the title
src/dmd/visitor.d
Outdated
| @@ -112,7 +112,8 @@ extern (C++) class SemanticTimeTransitiveVisitor : SemanticTimePermissiveVisitor | |||
| { | |||
| alias visit = SemanticTimePermissiveVisitor.visit; | |||
|
|
|||
| mixin ParseVisitMethods!ASTCodegen; | |||
| mixin ParseVisitMethods!ASTCodegen methods; | |||
There was a problem hiding this comment.
Perhaps prefix methods with two underscores or something. Because this symbol will be visible outside.
There was a problem hiding this comment.
Because this symbol will be visible outside.
I don't like it. With as powerful a language as D is, is there no way to make it private?
There was a problem hiding this comment.
Putting private before the mixin makes all the visit methods private. I don't know of any workaround.
There was a problem hiding this comment.
@jacob-carlborg Done, thanks!
There was a problem hiding this comment.
In my opinion, the compiler should do this automatically
Maybe file a bug about this, and put a comment with a link to that bug in the source code.
There was a problem hiding this comment.
Already did it : https://issues.dlang.org/show_bug.cgi?id=18132
RazvanN7
force-pushed
the
Mixin_Workaround
branch
from
f0ccdea to
d8bdfa1
Compare
|
👌. |
|
double underscores are reserved for compiler internal symbols! Thanks! |
This adds the same workaround to ParseTimeTransitiveVisitor, which has already been used for SemanticTimeTransitiveVisitor in dlang#7635.
This adds the same workaround to ParseTimeTransitiveVisitor, which has already been used for SemanticTimeTransitiveVisitor in dlang#7635.
This adds the same workaround to ParseTimeTransitiveVisitor, which has already been used for SemanticTimeTransitiveVisitor in #7635.
This adds the same workaround to ParseTimeTransitiveVisitor, which has already been used for SemanticTimeTransitiveVisitor in dlang/dmd#7635.
The methods which are mixed in aren't included in the overload set of the scope. This needs to be done manually. In my opinion, the compiler should do this automatically, but this PR only fixes the current issue so that calls to super.visit will be resolved correctly.