Allow bool as type for AA keys. #77

Merged
merged 1 commit into from Jun 5, 2011

Conversation

Projects
None yet
2 participants
@klickverbot
Member

klickverbot commented May 28, 2011

There doesn't really seem to be a reason why AA keys of type bool are not allowed, and the docs don't mention anything either. The restriction has been put in place back in the »bit« days, maybe there was a related limitation back then?

bool-key AAs probably wouldn't be too useful in practice, but it seems like a quite arbitrary and unexpected limitation to me – e.g. I would have to add special cases all over my Thrift map handling code.

WalterBright added a commit that referenced this pull request Jun 5, 2011

@WalterBright WalterBright merged commit a2d201d into dlang:master Jun 5, 2011

@klickverbot

This comment has been minimized.

Show comment
Hide comment
@klickverbot

klickverbot Jun 7, 2011

Member

This has been reverted in cce360c. Did my commit cause any bugs I hadn't noticed, or did the revert just slip in?

Member

klickverbot commented Jun 7, 2011

This has been reverted in cce360c. Did my commit cause any bugs I hadn't noticed, or did the revert just slip in?

@WalterBright

This comment has been minimized.

Show comment
Hide comment
@WalterBright

WalterBright Jul 4, 2011

Member

I guess this snafu demonstrates that test case code needs to be provided for each pull request.

Member

WalterBright commented Jul 4, 2011

I guess this snafu demonstrates that test case code needs to be provided for each pull request.

@klickverbot

This comment has been minimized.

Show comment
Hide comment
@klickverbot

klickverbot Jul 4, 2011

Member

Yes, absolutely – I am not quite sure why I didn't include the commit containing the test case here…

Member

klickverbot commented Jul 4, 2011

Yes, absolutely – I am not quite sure why I didn't include the commit containing the test case here…

@WalterBright

This comment has been minimized.

Show comment
Hide comment
@WalterBright

WalterBright Jul 4, 2011

Member

I restored it: 5ac7c66

Member

WalterBright commented Jul 4, 2011

I restored it: 5ac7c66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment