Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 18429 - alias this enum causes segmentation fault #7888

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

RazvanN7
Copy link
Contributor

If the identifier in the alias this declaration is defined later and is a voldemort type, we must perform semantic on the declaration to deduce the type.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
18429 normal alias this enum causes segmentation fault

@@ -245,6 +245,11 @@ private extern(C++) final class DsymbolSemanticVisitor : Visitor
Declaration d = sx.isDeclaration();
if (d && !d.isTupleDeclaration())
{
// Fix Issue 18429 : if the identifier in the alias this declaration
Copy link
Contributor

@JinShil JinShil Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of writing "Fix Issue 18429", I suggest just pasting the issue URL. It has the issue number in it, and gives the reader of the code immediate access the the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@stefan-koch-sociomantic

This might be indicative of other problems, I'd be on the look out for other places where the type is not set is not called.

@WalterBright
Copy link
Member

It would be nice to merge the test case into another file in the compilable directory, since fewer files make the autotester go faster.

@WalterBright
Copy link
Member

BTW @RazvanN7 thanks for the quick action on this bug!

@JinShil
Copy link
Contributor

JinShil commented Feb 14, 2018

The error in automem may be legitimate. I restarted Jenkins to see if it's reproducible.

UPDATE: Yep, look likes this may cause a regression. See the automem test in Jenkins.

@RazvanN7
Copy link
Contributor Author

@WalterBright

It would be nice to merge the test case into another file in the compilable directory, since fewer files make the autotester go faster.

Done.

@JinShil

Indeed, it was a regression, but I fixed it now.

@dlang-bot dlang-bot merged commit 5cc4309 into dlang:master Feb 14, 2018
@wilzbach
Copy link
Member

UPDATE: Yep, look likes this may cause a regression. See the automem test in Jenkins.
Indeed, it was a regression, but I fixed it now.

Wow. We added automem to the Projects Tester three days ago. I think @atilaneves will like this ;-)

@atilaneves
Copy link
Contributor

@wilzbach Can't complain ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants