-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 18429 - alias this enum causes segmentation fault #7888
Conversation
|
Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
src/dmd/dsymbolsem.d
Outdated
| @@ -245,6 +245,11 @@ private extern(C++) final class DsymbolSemanticVisitor : Visitor | |||
| Declaration d = sx.isDeclaration(); | |||
| if (d && !d.isTupleDeclaration()) | |||
| { | |||
| // Fix Issue 18429 : if the identifier in the alias this declaration | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of writing "Fix Issue 18429", I suggest just pasting the issue URL. It has the issue number in it, and gives the reader of the code immediate access the the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
1c27d74 to
040a3eb
Compare
|
This might be indicative of other problems, I'd be on the look out for other places where the type is not set is not called. |
|
It would be nice to merge the test case into another file in the |
|
BTW @RazvanN7 thanks for the quick action on this bug! |
|
The error in UPDATE: Yep, look likes this may cause a regression. See the automem test in Jenkins. |
040a3eb to
4bd9263
Compare
4bd9263 to
df08cb6
Compare
Done. Indeed, it was a regression, but I fixed it now. |
Wow. We added automem to the Projects Tester three days ago. I think @atilaneves will like this ;-) |
|
@wilzbach Can't complain ;) |
If the identifier in the alias this declaration is defined later and is a voldemort type, we must perform semantic on the declaration to deduce the type.