fix Issue 5212 - no escape analysis for typesafe variadic function ar… #7976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
|
WalterBright
force-pushed
the
fix5212
branch
3 times, most recently
from
7e5563d to
379633b
Compare
ibuclaw
approved these changes
Mar 3, 2018
| fparam.storageClass |= STC.variadic; | ||
| /* Don't need to set STC.scope_ because this will only | ||
| * be evaluated at compile time | ||
| */ |
There was a problem hiding this comment.
Shouldn't comments come before code in a block?
There was a problem hiding this comment.
In the other change, the setting of STC.scope_ came after.
| @@ -604,7 +604,7 @@ private bool functionParameters(Loc loc, Scope* sc, TypeFunction tf, Type tthis, | |||
| nargs++; | |||
| } | |||
|
|
|||
| if (tf.varargs == 2 && i + 1 == nparams) | |||
| if (tf.varargs == 2 && i + 1 == nparams) // https://dlang.org/spec/function.html#variadic | |||
There was a problem hiding this comment.
Maybe the link should be put on the line before this condition. Perhaps with a slight introduction also, eg: Handle variadic arguments as per spec <link>.
There was a problem hiding this comment.
The spec link implies just that.
There was a problem hiding this comment.
The comment still - to me at least - looks to be in an awkward place. But well, eye of the beholder and all.
src/dmd/semantic3.d
Outdated
| /* Since it'll be pointing into the stack for the array | ||
| * contents, it needs to be `scope` | ||
| */ | ||
| stc |= STC.scope_; |
There was a problem hiding this comment.
Multiline indent should probably be given braces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…guments
The fix is implicitly adding the
scopeannotation.