Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 18644 - [dip1000] escape of outer local not detected #8062

Merged
merged 1 commit into from Mar 22, 2018
Merged

fix Issue 18644 - [dip1000] escape of outer local not detected #8062

merged 1 commit into from Mar 22, 2018

Conversation

WalterBright
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 18644 normal [dip1000] escape of outer local not detected

JinShil
JinShil approved these changes Mar 21, 2018
View reviewed changes
Copy link
Contributor

@JinShil JinShil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to avoid the code duplication.

@WalterBright WalterBright merged commit 0e0df72 into dlang:master Mar 22, 2018
@WalterBright WalterBright deleted the fix18644 branch March 22, 2018 00:08
@WalterBright
Copy link
Member Author

duplication

It used to be all together, with a maze of conditional statements. It was impossible to deal with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinShil JinShil JinShil approved these changes

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
No milestone
3 participants
@WalterBright @dlang-bot @JinShil