Fix Issue 18647 - Use of delete should be allowed without a deprecation in a deprecated scope #8066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinShil
approved these changes
Mar 21, 2018
| // 3. Removal of keyword, "delete" can be used for other identities | ||
| if (!exp.isRAII) | ||
| deprecation(exp.loc, "The `delete` keyword has been deprecated. Use `object.destroy()` (and `core.memory.GC.free()` if applicable) instead."); | ||
| } |
There was a problem hiding this comment.
The bug report was more general (before you changed the title).
I took delete as an example, because it's what hits me, but I'm pretty sure it affects other deprecations.
For example:
deprecated void main ()
{
int i, o;
switch (i)
{
case 1:
o = 1;
case 2:
o = 2;
break;
default:
}
}There was a problem hiding this comment.
OKay I created a new subissue 18647 of 17906 which just addresses the delete deprecation.
Maybe deprecation should require the current scope, s.t. sc.isDeprecated can automatically be called (and we don't need to patch this in at all places)?
…on in a deprecated scope
wilzbach
changed the title
1 similar comment
|
@wilzbach In the future, please note in bugzilla that this PR exists. I did it for this one. |
| @@ -0,0 +1,6 @@ | |||
| // REQUIRED_ARGS: -de | |||
There was a problem hiding this comment.
Please add the corresponding bugzilla issue as a comment.
add bugzilla link
WalterBright
approved these changes
Mar 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targetting stable as this is rather relevant to the
deletedeprecation that was part of 2.079