Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 16189 - Optimizer bug, with simple test case #8074

Merged
merged 1 commit into from
Mar 26, 2018
Merged

fix Issue 16189 - Optimizer bug, with simple test case #8074

merged 1 commit into from
Mar 26, 2018

Conversation

WalterBright
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Mar 24, 2018 •
edited
Loading

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 16189 critical Optimizer bug, with simple test case

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8074"

jacob-carlborg
jacob-carlborg reviewed Mar 24, 2018
View reviewed changes
test/runnable/mars1.d Outdated
a--;
bool b = false;
if (b) goto loop;
assert(a == -1); // Fails with -O
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment still be here? I assume the assert does not fail now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Past tense "Failed"? Doesn't bother me really.

ibuclaw
ibuclaw approved these changes Mar 25, 2018
View reviewed changes
Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walter's backend, trust he knows what he is doing.

@wilzbach wilzbach merged commit 88a963a into dlang:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-carlborg jacob-carlborg jacob-carlborg left review comments

@ibuclaw ibuclaw ibuclaw approved these changes

Assignees
No one assigned
Labels
Merge:auto-merge Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WalterBright @dlang-bot @jacob-carlborg @ibuclaw @wilzbach