Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7751 - [ICE] From auto and forward reference #828

Merged
merged 1 commit into from
Mar 29, 2012

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Mar 24, 2012

@9rnsr
Copy link
Contributor Author

9rnsr commented Mar 24, 2012

I htink bug7751 is a regression caused by my lambda inference changes.

@donc
Copy link
Collaborator

donc commented Mar 28, 2012

I think bug7751 is a regression caused by my lambda inference changes.
I'm not sure about that, I don't think it should get that far. I think the problem is that in BinAssign::op_overload(), it looks for alias this, even if there was an error in e1 or e2.
My alternative fix is only two lines:
don-clugston-sociomantic@6103606
Please comment.

@9rnsr
Copy link
Contributor Author

9rnsr commented Mar 29, 2012

Sorry for my late reply.
My fix will increase code robustness, inferType can receive NULL type as its argument.
On the other hand, your fix will improve semantic error handling.
I think both should be merged.

@donc
Copy link
Collaborator

donc commented Mar 29, 2012

Excellent, that was my feeling, too. I will open mine as pull request.

@9rnsr
Copy link
Contributor Author

9rnsr commented Mar 29, 2012

Good.

WalterBright added a commit that referenced this pull request Mar 29, 2012
Issue 7751 - [ICE] From auto and forward reference
@WalterBright WalterBright merged commit cd7d2fc into dlang:master Mar 29, 2012
braddr pushed a commit to braddr/dmd that referenced this pull request Oct 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants