Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 19070 - Deprecate octal literal 00 through 07 #8490

Closed
wants to merge 1 commit into from

Conversation

kubo39
Copy link
Contributor

@kubo39 kubo39 commented Jul 12, 2018

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19070 trivial Invalid octal literals 01 through 07 allowed

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8490"

@kubo39
Copy link
Contributor Author

kubo39 commented Jul 12, 2018

Octal literals widely used than I thought. It's better to allow only 01 through 07 as decimal literals, maybe.

@Geod24
Copy link
Member

Geod24 commented Jul 13, 2018

@kubo39 : D has a long history of not imposing unnecessary restrictions. This is a goof example of it IMO.
I don't think we are going to get rid of the error message, since it would break compatibility with C code, but disallowing 01 through 07 doesn't seem to add any value for the end user.

@kubo39
Copy link
Contributor Author

kubo39 commented Jul 13, 2018

I think so too, okay, close this.

@kubo39 kubo39 closed this Jul 13, 2018
@kubo39 kubo39 deleted the deprecated-octal-literals branch July 13, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants