Issue 7786 - dmd crashes with invalid module name #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #if TARGET_NET //dot net needs modules and packages with same name | ||
| #else | ||
| if (p->isModule()) | ||
| { p->error("module and package have the same name"); |
There was a problem hiding this comment.
No no no!
Getting rid of that ridiculous error message was the whole point of the original commit.
The module and package DO NOT HAVE THE SAME NAME.
There was a problem hiding this comment.
If we remove this error message, following Example compiles WITHOUT errors.
It is another regression (see bugzilla issue 7786 and the outputs in 2.058).
Agreed, but adding a nonsense error message is not a good solution.
|
Alternative pull request gives a nicer error message: |
|
Pull #864 is better than this, so I close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=7786