Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issues 16082 and 16086 #8885

Merged
merged 3 commits into from
Nov 5, 2018
Merged

Fix Issues 16082 and 16086 #8885

merged 3 commits into from
Nov 5, 2018

Conversation

RazvanN7
Copy link
Contributor

Look for aliasthis before checking upper scopes.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
16082 normal Can't access alias this member with same name as module
16086 normal Imported function name shadows alias this member

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8885"

@RazvanN7 RazvanN7 changed the title Fix Issue 16082 and 16086 Fix Issues 16082 and 16086 Oct 29, 2018
@RazvanN7
Copy link
Contributor Author

@WalterBright Is this solution better?

@patrickkh7788
Copy link

can you take a look at this maybe related: https://issues.dlang.org/show_bug.cgi?id=19327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants