fix Issue 1175 - nested class inheritance #889

Merged
merged 1 commit into from Apr 19, 2012

Conversation

Projects
None yet
4 participants
Owner

CyberShadow commented Apr 19, 2012

A simple change - however, I'm not well-versed in DMD internals, so please check this before merging.

@ghost

ghost commented Apr 19, 2012

It's interesting that this works ok with static classes:

class Foo
{
    static class FooNest { }
}

class Bar : Foo
{
    class BaseNest : FooNest { }
}

I think I've used this once as a workaround for this bug.

@WalterBright WalterBright added a commit that referenced this pull request Apr 19, 2012

@WalterBright WalterBright Merge pull request #889 from CyberShadow/fix-2342
fix Issue 1175 - nested class inheritance
4db669e

@WalterBright WalterBright merged commit 4db669e into dlang:master Apr 19, 2012

@WalterBright WalterBright added a commit that referenced this pull request Apr 19, 2012

@WalterBright WalterBright merge D2 pull #889 7722b7e
Owner

braddr commented Apr 20, 2012

This pull broke the master builds, and also didn't pass the tests before it was pulled.. silly Walter, why'd you merge it?

Owner

CyberShadow commented Apr 20, 2012

Sorry about this, I'll see if I can get this sorted out.

Brad, would it be possible to add a text file with instructions on how to run the test suite, especially on Windows? It's unclear which file you run (the shell script or the makefile), and what environment you need (Cygwin/etc.)

Looking at autotester logs, I guess the test suite keeps going even after a failed test? That would be why I missed the test failure. Interpreting the output should be in the file with instructions as well.

Member

JakobOvrum commented Apr 20, 2012

To be fair, the autotester isn't that easy to figure out and pretty hard to find, too.

Owner

CyberShadow commented Apr 20, 2012

Ah, I see that Kenji beat me to it (pull #893). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment