Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 1175 - nested class inheritance #889

Merged
merged 1 commit into from
Apr 19, 2012

Conversation

CyberShadow
Copy link
Member

A simple change - however, I'm not well-versed in DMD internals, so please check this before merging.

@ghost
Copy link

ghost commented Apr 19, 2012

It's interesting that this works ok with static classes:

class Foo
{
    static class FooNest { }
}

class Bar : Foo
{
    class BaseNest : FooNest { }
}

I think I've used this once as a workaround for this bug.

WalterBright added a commit that referenced this pull request Apr 19, 2012
fix Issue 1175 - nested class inheritance
@WalterBright WalterBright merged commit 4db669e into dlang:master Apr 19, 2012
WalterBright added a commit that referenced this pull request Apr 19, 2012
@braddr
Copy link
Member

braddr commented Apr 20, 2012

This pull broke the master builds, and also didn't pass the tests before it was pulled.. silly Walter, why'd you merge it?

@CyberShadow
Copy link
Member Author

Sorry about this, I'll see if I can get this sorted out.

Brad, would it be possible to add a text file with instructions on how to run the test suite, especially on Windows? It's unclear which file you run (the shell script or the makefile), and what environment you need (Cygwin/etc.)

Looking at autotester logs, I guess the test suite keeps going even after a failed test? That would be why I missed the test failure. Interpreting the output should be in the file with instructions as well.

@JakobOvrum
Copy link
Member

To be fair, the autotester isn't that easy to figure out and pretty hard to find, too.

@CyberShadow
Copy link
Member Author

Ah, I see that Kenji beat me to it (pull #893). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants