fix Issue 19318 - Variables captured from outer functions not visible in debugger

[rainers]

create struct type corresponding to the stack variables that are captured by nested functions and assign it to the context pointer in the nested function.

[dlang-bot]

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	19318	normal	Variables captured from outer functions not visible in debugger

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8906"

[thewilsonator]

@rainers any idea whats with the Win32 failures?

HOST_DC=/home/braddr/sandbox/at-client/release-build/dmd-2.079.0/windows/bin/dmd.exe
HOST_DC=C:\cygwin\home\braddr\sandbox\at-client\release-build\dmd-2.079.0\windows\bin\dmd.exe
cd test
gmake -j3
Creating output directory: test_results
Building d_do_test tool
Building sanitize_json tool
OS: 'win32'
OS: 'win32'
MODEL: '32'
MODEL: '32'
PIC: ''
../generated/windows/release/32/dmd.exe -conf= -m32  -g -unittest -run tools/d_do_test.d
PIC: ''
../generated/windows/release/32/dmd.exe -conf= -m32  -g -odtest_results -oftest_results\\sanitize_json.exe -i tools/sanitize_json.d
Error: linker exited with status 1
Makefile:171: recipe for target 'test_results/d_do_test.exe' failed
gmake: *** [test_results/d_do_test.exe] Error 1

--- errorlevel 2

[rainers]

@rainers any idea whats with the Win32 failures?

Oops, that's a crash in optlink.

[thewilsonator]

Wonderful, how do we proceed from here then?

[rainers]

I have investigated it a bit:

• I suspect optlink doesn't like the negative offsets that are specified for the struct members
• it also crashes if I make them unsigned, but large (works ok with COFF, too, but looks ugly when dumped)
• objtoasm also doesn't understand these records
• cv2pdb strips the hidden context pointers anyway due to inconsistent debug information with the function type

-> I'll just disable the output for OMF