Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 15876 - various cases of SEGFAULT when formatting parser errors #9007

Merged
merged 2 commits into from Nov 24, 2018
Merged

fix issue 15876 - various cases of SEGFAULT when formatting parser errors #9007

merged 2 commits into from Nov 24, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 24, 2018

Just added some checks before the unsafe accesses pointed by GDB when running the test cases.

@ghost ghost requested a review from WalterBright as a code owner November 24, 2018 15:44
@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 24, 2018

Thanks for your pull request and interest in making D better, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
15876 normal various cases of SEGFAULT when formatting parser errors

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9007"

@dlang-bot dlang-bot merged commit da15e2f into dlang:master Nov 24, 2018
@ghost ghost deleted the hdrgen-unsafe-accesses branch November 25, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants