-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Issue 19473 - DMD Segfault on circular struct reference #9072
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#9072" |
eff5e88 to
d876f39
Compare
|
Again, please target stable. |
d876f39 to
ee86365
Compare
|
Of course, the instructions for rebasing to stable do not work. It still shows 'master'. |
|
Try step 2: https://blog.github.com/2016-08-15-change-the-base-branch-of-a-pull-request |
|
That shows a nice graphic and master with a pulldown menu, but that does not exist on this page. |
|
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the new member to headers.
(It won't be used directly, the glue layer only cares that the value == SIZEOKdone, however this PR would mean such a comparison would start failing).
ee86365 to
d2b6fc9
Compare

Another ancient regression from DMD 2.071