Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 19473 - DMD Segfault on circular struct reference #9072

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

WalterBright
Copy link
Member

Another ancient regression from DMD 2.071

@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 12, 2018

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
19473 regression DMD Segfault on circular struct reference

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9072"

@thewilsonator
Copy link
Contributor

Again, please target stable.

@WalterBright
Copy link
Member Author

Of course, the instructions for rebasing to stable do not work. It still shows 'master'.

@WalterBright
Copy link
Member Author

mercury~/forks/dmd/test/fail_compilation fix19473> git rebase --onto upstream/stable upstream/master
First, rewinding head to replay your work on top of it...
Applying: fix Issue 19473 - DMD Segfault on circular struct reference
mercury~/forks/dmd/test/fail_compilation fix19473> git push -f origin fix19473
Counting objects: 51, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 852 bytes | 0 bytes/s, done.
Total 8 (delta 7), reused 0 (delta 0)
remote: Resolving deltas: 100% (7/7), completed with 7 local objects.
To git@github.com:WalterBright/dmd.git
 + d876f39...ee86365 fix19473 -> fix19473 (forced update)
base --onto upstream/stable upstream/masterx19473>

@wilzbach
Copy link
Member

Of course, the instructions for rebasing to stable do not work. It still shows 'master'.

Try step 2: https://blog.github.com/2016-08-15-change-the-base-branch-of-a-pull-request

@WalterBright
Copy link
Member Author

That shows a nice graphic and master with a pulldown menu, but that does not exist on this page.

@wilzbach
Copy link
Member

Yes, you need to click on "Edit".

fbc7e2e4-62d9-11e6-8954-44ac9f5317e6

@WalterBright WalterBright changed the base branch from master to stable December 13, 2018 05:29
@WalterBright
Copy link
Member Author

Thank you!

Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new member to headers.

(It won't be used directly, the glue layer only cares that the value == SIZEOKdone, however this PR would mean such a comparison would start failing).

@WalterBright WalterBright dismissed ibuclaw’s stale review December 13, 2018 10:49

added to headers

@thewilsonator thewilsonator merged commit 5aa95b5 into dlang:stable Dec 13, 2018
@WalterBright WalterBright deleted the fix19473 branch December 13, 2018 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants