fix Issue 19227 - S.init is S.init failing for struct with float member #9073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#9073" |
WalterBright
force-pushed
the
fix19227
branch
from
ee08e5d to
e1dce1a
Compare
n8sh
reviewed
Dec 13, 2018
| @@ -1254,9 +1261,11 @@ private int ctfeRawCmp(const ref Loc loc, Expression e1, Expression e2) | |||
| { | |||
| real_t r1 = e1.type.isreal() ? e1.toReal() : e1.toImaginary(); | |||
| real_t r2 = e1.type.isreal() ? e2.toReal() : e2.toImaginary(); | |||
| if (identity) | |||
| return !RealEquals(r1, r2); | |||
There was a problem hiding this comment.
Note: RealEquals corresponds to is rather than == (all NaNs are equal, +0.0 and -0.0 are unequal), so it's correct.
n8sh
approved these changes
Dec 13, 2018
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.