Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 19202 - deprecated eponymous template prints no warning #9079

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

RazvanN7
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 14, 2018

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19202 regression deprecated eponymous template prints no warning

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9079"

@RazvanN7 RazvanN7 force-pushed the Issue_19202 branch 2 times, most recently from 02e3daa to 44c1f1e Compare December 14, 2018 14:26
@RazvanN7 RazvanN7 changed the base branch from master to stable December 14, 2018 14:26
---
*/

void main() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curly braces should be on their own lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@WalterBright
Copy link
Member

@RazvanN7 something's up with appveyor

@RazvanN7
Copy link
Contributor Author

@WalterBright It's unrelated to this PR. It always appears when you target stable. I think that @TurkeyMan 's C++ namespace PR wasn't merged in stable.

@thewilsonator
Copy link
Contributor

Test fail_compilation/fail19202.d failed: 
expected:
----
fail_compilation/fail19202.d(10): Deprecation: variable `fail19202.X!().X` is deprecated
----
actual:
----
fail_compilation/fail19202.d(11): Deprecation: variable `fail19202.X!().X` is deprecated

@RazvanN7
Copy link
Contributor Author

@thewilsonator yeah, forgot to update the line number. Should be good now

@dlang-bot dlang-bot merged commit 07aff0b into dlang:stable Dec 17, 2018
@wilzbach
Copy link
Member

AUTO_UPDATE=1 is your friend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants