fix Issue 16652 - [Reg 2.071] returned rvalue destroyed too early #9081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
|
src/dmd/inline.d
Outdated
| * m = module to scan | ||
| */ | ||
| public void inlineScanModule(Module m) | ||
| { |
WalterBright
force-pushed
the
fix16652
branch
from
7c8cb19 to
dc459ce
Compare
|
Hmm. What's different about the circleci machines from the Linux ones that are passing? |
|
|
|
|
|
Guess it's time to start a binary bisect of sdtor.d. |
WalterBright
force-pushed
the
fix16652
branch
5 times, most recently
from
0750b3c to
80516e2
Compare
WalterBright
force-pushed
the
fix16652
branch
from
80516e2 to
535e8a4
Compare
|
Hah, fixing this exposed another RAII bug, which I'm glad to fix. |
thewilsonator
approved these changes
Dec 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ugly bug that makes RAII unreliable.
The fix is to inline functions as expressions, not statements, when the arguments to the function generate temporaries that need destruction. The destruction has to happen after the function body executes, and the code generator handles that nicely when they are expressions.