Fix Issue 16214 - [REG2.069] ICE: Assertion fd->semanticRun == PASSsemantic3done failed

[RazvanN7]

The commented line was added by [1] to fix [2]. However, the example compiles just fine without it; moreover it seems to introduce a regression.

Since it is an old regression, I didn't target stable. This has the advantage that buildkite and appveyor may test it (those are broken on stable).

[1] #5166
[2] https://issues.dlang.org/show_bug.cgi?id=15149

[dlang-bot]

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	16214	regression	[REG2.069] ICE: Assertion `fd->semanticRun == PASSsemantic3done' failed.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9101"

[jacob-carlborg]

Why leave it?

[RazvanN7]

Because I'm not sure that it works for all cases. If a bug report appears at some point, the person that will fix will have some hints to some resources. I've seen this pattern in some parts of the compiler.

[jacob-carlborg]

There's the Git history as well.