Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce nesting in blassertsplit #9202

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Conversation

thewilsonator
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9202"

@thewilsonator
Copy link
Contributor Author

the performance of this function is O(very bad), I want to refactor it a bit before making it O(acceptable)

@WalterBright
Copy link
Member

I presume this is about https://issues.dlang.org/show_bug.cgi?id=19550

@thewilsonator
Copy link
Contributor Author

Yes.

@WalterBright
Copy link
Member

I put a link to this in 19550.

@thewilsonator
Copy link
Contributor Author

N.B. this doesn't fix that issue, I'm just beautifying the code beforehand. I don't really understand the code other than that it does what appears to be an awful lot of nested looping.

src/dmd/backend/blockopt.d Outdated Show resolved Hide resolved
@thewilsonator thewilsonator added Merge:72h no objection -> merge The PR will be merged if there are no objections raised. Merge:auto-merge and removed Merge:72h no objection -> merge The PR will be merged if there are no objections raised. labels Jan 15, 2019
@dlang-bot dlang-bot merged commit 5574da0 into dlang:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants