Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 19639 #9317

Closed
wants to merge 1 commit into from
Closed

Fix issue 19639 #9317

wants to merge 1 commit into from

Conversation

dhasenan
Copy link
Contributor

@dhasenan dhasenan commented Feb 2, 2019

When doing a reinterpret cast on a string literal to a static array, ensure the static array has enough capacity.

This is a minimal bandaid fix for issue 19639. It changes the behavior of a construct that has been broken at least since 2015, from giving garbage data to a compile-time error. It also fixes a segfault.

When doing a reinterpret cast on a string literal to a static array,
ensure the static array has enough capacity.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dhasenan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19639 regression Initializing static array with slice enum of different length crashes the compiler

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9317"

@dhasenan dhasenan closed this Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants